This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: i386 fp moves changes
- To: Jan Hubicka <hubicka at atrey dot karlin dot mff dot cuni dot cz>
- Subject: Re: i386 fp moves changes
- From: Richard Henderson <rth at cygnus dot com>
- Date: Mon, 3 Jan 2000 14:06:34 -0800
- Cc: egcs-patches at egcs dot cygnus dot com
- References: <19991230233448.C409@atrey.karlin.mff.cuni.cz>
On Thu, Dec 30, 1999 at 11:34:48PM +0100, Jan Hubicka wrote:
> * i386.c (ix86_expand_move): Allow pushes of memory, offload to memory
> all FP constants for constant->reg moves.
> (ix86_split_to_parts): Try to convert memory address into immediate
> when available in the constant pool.
> * i386.h (PREFERRED_RELOAD_CLASS): Allow CONST_DOUBLE->integer reg
> moves.
> (LEGITIMATE_CONSTANT_P): Return 1.
> * i386.md (pushsf): New splitter to convert constant pool memory
> reference to immediate.
> (mov?f): Likewise; do not allow CONST_DOUBLE for reg moves before
> reload.
Ok.
> ! if (GET_CODE (operands[0]) == MEM && !push_operand (operands[0], mode)
> ! && GET_CODE (operands[1]) == MEM)
> operands[1] = force_reg (mode, operands[1]);
I'd prefer to see things like this written one condition per line.
Only combine conditionals on a line if the whole thing fits.
r~