This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch for format non-literal warnings
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: Patch for format non-literal warnings
- From: Richard Henderson <rth at cygnus dot com>
- Date: Sun, 26 Dec 1999 13:15:55 -0800
- Cc: egcs-patches at egcs dot cygnus dot com
- References: <199912261419.JAA26273@caip.rutgers.edu>
On Sun, Dec 26, 1999 at 09:19:30AM -0500, Kaveh R. Ghazi wrote:
> if (p > _(msgid)) /* Print the left-hand substring. */
> - {
> - char fmt[sizeof "%.255s"];
> - long width = p - _(msgid);
> -
> - if (width > 255L) width = 255L; /* arbitrary */
> - sprintf (fmt, "%%.%lds", width);
> - fprintf (stderr, fmt, _(msgid));
> - }
> + fprintf (stderr, "%.*s", (int)(p - _(msgid)), _(msgid));
This is probably ok, though I wonder if we'll run into
trouble with old libcs...
> - fprintf (file, buf, va_arg (argptr, int));
> + vfprintf (file, buf, argptr);
This is not a valid replacement. The later does not (always) consume
an argument from the local `argptr'.
r~