This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Associate a name with a CODE_LABEL
- To: richard dot earnshaw at arm dot com
- Subject: Re: [patch] Associate a name with a CODE_LABEL
- From: Catherine Moore <clm at cygnus dot com>
- Date: Thu, 11 Nov 1999 08:56:55 -0800
- cc: Catherine Moore <clm at cygnus dot com>, Richard Henderson <rth at cygnus dot com>, gcc-patches at gcc dot gnu dot org, clm at cygnus dot com
I've fixed up default.h based on this suggestion.
Okay to commit?
* defaults.h (ASM_OUTPUT_ALTERNATE_LABEL_NAME): Use
ASM_OUTPUT_LABEL.
Index: defaults.h
===================================================================
RCS file: /cvs/cvsfiles/devo/gcc/defaults.h,v
retrieving revision 1.27
diff -p -r1.27 defaults.h
*** defaults.h 1999/11/03 13:47:01 1.27
--- defaults.h 1999/11/11 16:52:43
*************** do { fprintf (FILE, "\t%s\t", ASM_LONG);
*** 57,63 ****
/* Provide default for ASM_OUTPUT_ALTERNATE_LABEL_NAME. */
#ifndef ASM_OUTPUT_ALTERNATE_LABEL_NAME
#define ASM_OUTPUT_ALTERNATE_LABEL_NAME(FILE,INSN) \
! fprintf (FILE, "%s:\n", LABEL_ALTERNATE_NAME (INSN))
#endif
/* choose a reasonable default for ASM_OUTPUT_ASCII. */
--- 57,63 ----
/* Provide default for ASM_OUTPUT_ALTERNATE_LABEL_NAME. */
#ifndef ASM_OUTPUT_ALTERNATE_LABEL_NAME
#define ASM_OUTPUT_ALTERNATE_LABEL_NAME(FILE,INSN) \
! ASM_OUTPUT_LABEL(FILE,LABEL_ALTERNATE_NAME (INSN))
#endif
/* choose a reasonable default for ASM_OUTPUT_ASCII. */
:
:clm@cygnus.com said:
: + /* Provide default for ASM_OUTPUT_ALTERNATE_LABEL_NAME. */
: + #ifndef ASM_OUTPUT_ALTERNATE_LABEL_NAME
: + #define ASM_OUTPUT_ALTERNATE_LABEL_NAME(FILE,INSN) \
: + fprintf (FILE, "%s:\n", LABEL_ALTERNATE_NAME (INSN))
: + #endif
: +
:
:This on its own will mean that any port that does not use ':' as a label
:declaration will now be broken (the arm-aof port springs to mind). Would
:it not be better to define this in terms of some other label_generation
:macro (I'm not entirely sure of the intended use, but ASM_OUTPUT_LABEL
:might be more appropriate).