This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: arm configure --with-cpu nitpick
- To: Jonathan Larmour <jlarmour at peshwari dot cygnus dot co dot uk>
- Subject: Re: arm configure --with-cpu nitpick
- From: Richard Earnshaw <rearnsha at arm dot com>
- Date: Fri, 08 Oct 1999 14:59:02 +0100
- Cc: gcc-patches at gcc dot gnu dot org
- Cc: richard dot earnshaw at arm dot com
- Organization: ARM Ltd.
- Reply-To: richard dot earnshaw at arm dot com
Yes, there's a problem here; thanks for pointing it out. However, I
believe the preferred solution going by example from elsewhere in the file
is to use changequote() to temporarily change the quoting characters --
see arm-*-riscix1 for an example.
Richard.
> The following patch fixes an obvious nitpick that shows up when configuring
> with e.g. --with-cpu=arm7. The brackets get stripped by autoconf.
>
> Can someone check this in please?
>
> Ta,
>
> Jifl
>
> Fri Oct 8 14:44:16 1999 Jonathan Larmour <jlarmour@cygnus.co.uk>
>
> * configure.in (arm*-*-*): bracket arm core versions correctly
> * configure: regenerate
>
> Index: configure
> ===================================================================
> RCS file: /egcs/carton/cvsfiles/egcs/gcc/configure,v
> retrieving revision 1.289
> diff -u -5 -p -r1.289 configure
> --- configure 1999/10/07 08:15:18 1.289
> +++ configure 1999/10/08 13:46:36
> @@ -6267,11 +6267,11 @@ for machine in $build $host $target; do
> target_cpu_default2="TARGET_CPU_generic"
> ;;
>
> # Distinguish cores, and major variants
> # arm7m doesn't exist, but D & I don't affect code
> - xarm23678 | xarm250 | xarm67010 \
> + xarm[23678] | xarm250 | xarm[67][01]0 \
> | xarm7m | xarm7dm | xarm7dmi | xarm7tdmi \
> | xarm7100 | xarm7500 | xarm7500fe | xarm810 \
> | xstrongarm | xstrongarm110 | xstrongarm1100)
> target_cpu_default2="TARGET_CPU_$with_cpu"
> ;;
> Index: configure.in
> ===================================================================
> RCS file: /egcs/carton/cvsfiles/egcs/gcc/configure.in,v
> retrieving revision 1.295
> diff -u -5 -p -r1.295 configure.in
> --- configure.in 1999/10/07 08:15:17 1.295
> +++ configure.in 1999/10/08 13:46:40
> @@ -3585,11 +3585,11 @@ changequote([,])dnl
> target_cpu_default2="TARGET_CPU_generic"
> ;;
>
> # Distinguish cores, and major variants
> # arm7m doesn't exist, but D & I don't affect code
> - xarm[23678] | xarm250 | xarm[67][01]0 \
> + xarm[[23678]] | xarm250 | xarm[[67]][[01]]0 \
> | xarm7m | xarm7dm | xarm7dmi | xarm7tdmi \
> | xarm7100 | xarm7500 | xarm7500fe | xarm810 \
> | xstrongarm | xstrongarm110 | xstrongarm1100)
> target_cpu_default2="TARGET_CPU_$with_cpu"
> ;;