This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: C++ PATCH: Reimplementation of error.c
- To: Mark Mitchell <mark at codesourcery dot com>
- Subject: Re: C++ PATCH: Reimplementation of error.c
- From: Nathan Sidwell <nathan at acm dot org>
- Date: Mon, 27 Sep 1999 09:36:59 +0100
- CC: nathan at compsci dot bristol dot ac dot uk, egcs-patches at egcs dot cygnus dot com, gdr at codesourcery dot com
- References: <37E79D37.1C9F2667@acm.org> <19990921142345L.mitchell@codesourcery.com>
- Reply-To: nathan at compsci dot bristol dot ac dot uk
Mark Mitchell wrote:
>
>
> Why do we get additional error messages with the new stuff? Were
> there any regressions with your patch (beyond the new printing for
> __PRETTY_FUNCTION__ in a couple of places)?
This was to do with IDENTIFIER_TEMPLATE, now I no longer effect that,
there are no extra errors.
> I don't like the printing of `X<>' for the type `X' in `template
> <class T> struct X'. Let's just print that as `X', which I think is a
> lot more intuitive to most folks. It's also better than `X<T>' which
> is what we do now, and which is also unclear.
Done.
> I don't understand what you did to IDENTIFIER_TEMPLATE. This used to
This is no longer effected (modulo calls to type_as_string etc being
adjusted).
> This ChangeLog entry is too long. Put it on two lines.
Oops, just done that.
> Why do some error messages that used to have `#' no longer need them,
> while others that didn't need `#' now do have it? What about the
> defaults changed? Why?
Because I'd not quite managed to duplicate the previous behaviour wrt
TEMPLATE_DECLS. However, I now DTRT and no error messages need dinking.
> Would you explain that, make those changes, and install the patch,
> assuming there aren't any real regressions with it?
No regressions other than g++.pt/memtemp77.C which needed it's expected
__PRETTY_FUNCTION__ altering.
Over to you Gaby.
nathan
--
Dr Nathan Sidwell :: Computer Science Department :: Bristol University
I have seen the death of PhotoShop -- it is called GIMP
nathan@acm.org http://www.cs.bris.ac.uk/~nathan/ nathan@cs.bris.ac.uk
error4.patch.gz
Mon Sep 27 09:14:24 BST 1999 Nathan Sidwell <nathan@acm.org>
* g++.old-deja/g++.pt/memtemp77.C: Adjust expected
__PRETTY_FUNCTION__.
Index: testsuite/g++.old-deja/g++.pt/memtemp77.C
===================================================================
RCS file: /cvs/egcs/egcs/gcc/testsuite/g++.old-deja/g++.pt/memtemp77.C,v
retrieving revision 1.3
diff -c -3 -p -r1.3 memtemp77.C
*** memtemp77.C 1998/12/16 21:59:01 1.3
--- memtemp77.C 1999/09/27 08:27:08
*************** char* S3<char>::h(int) { return __PRETTY
*** 18,24 ****
int main()
{
if (strcmp (S3<double>::h(7),
! "static char * S3<double>::h<int>(int)") == 0)
return 0;
else
return 1;
--- 18,24 ----
int main()
{
if (strcmp (S3<double>::h(7),
! "char *S3<double>::h<int> (int)") == 0)
return 0;
else
return 1;
log.raw.diff.gz
log.cooked.diff.gz