This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: m32r fixes


On Wed, Sep 15, 1999 at 05:47:12PM -0700, Richard Henderson wrote:
> There are several important changes in here
> 
> (1) Since Kaveh added the predicate prototypes to insn-output,
>     they conflict with the stuff done in m32r.h, which are 
>     technically incorrect.
> 
>     Given that we can't in general prototype stuff in tm.h
>     (yes, I recall Bernd has had patches to do this forever),
>     I hade them all behind XPROTO like I did for new ia32.
> 
> (2) The declared variable swap_p was used as must_swap.  This
>     must have been broken for a while.
> 
> (3) Since one of Zack's patches, there is no function fatal_insn;
>     it is a macro in toplev.h.  Since insn-output.c doesn't 
>     include that, we get fatal_insn undefined at link.  Just 
>     using abort in this one situation seems easiest.

I probably would include toplev.h, since I generally prefer fatal_insn if you
have an insn in hand.

> The rest is standard warning cleanup.
> 
> Ok?

Yes.

-- 
Michael Meissner, Cygnus Solutions
PMB 198, 174 Littleton Road #3, Westford, Massachusetts 01886
email: meissner@cygnus.com	phone: 978-486-9304	fax: 978-692-4482


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]