This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: m32r fixes
- To: Richard Henderson <rth at cygnus dot com>, gcc-patches at gcc dot gnu dot org
- Subject: Re: m32r fixes
- From: Michael Meissner <meissner at cygnus dot com>
- Date: Wed, 15 Sep 1999 21:46:45 -0400
- Cc: Nick Clifton <nickc at cygnus dot com>, Michael Meissner <meissner at cygnus dot com>
- References: <19990915174712.A8521@cygnus.com>
On Wed, Sep 15, 1999 at 05:47:12PM -0700, Richard Henderson wrote:
> There are several important changes in here
>
> (1) Since Kaveh added the predicate prototypes to insn-output,
> they conflict with the stuff done in m32r.h, which are
> technically incorrect.
>
> Given that we can't in general prototype stuff in tm.h
> (yes, I recall Bernd has had patches to do this forever),
> I hade them all behind XPROTO like I did for new ia32.
>
> (2) The declared variable swap_p was used as must_swap. This
> must have been broken for a while.
>
> (3) Since one of Zack's patches, there is no function fatal_insn;
> it is a macro in toplev.h. Since insn-output.c doesn't
> include that, we get fatal_insn undefined at link. Just
> using abort in this one situation seems easiest.
I probably would include toplev.h, since I generally prefer fatal_insn if you
have an insn in hand.
> The rest is standard warning cleanup.
>
> Ok?
Yes.
--
Michael Meissner, Cygnus Solutions
PMB 198, 174 Littleton Road #3, Westford, Massachusetts 01886
email: meissner@cygnus.com phone: 978-486-9304 fax: 978-692-4482