This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Patch checked in for more warnings nits


	Here are a few more warning nits I zapped, this time on OSF4.

		--Kaveh

../../egcs-CVS19990913/gcc/c-pragma.c: In function `handle_pragma_token':
../../egcs-CVS19990913/gcc/c-pragma.c:240: warning: unused variable `align'
../../egcs-CVS19990913/gcc/c-pragma.c:239: warning: unused variable `value'
../../egcs-CVS19990913/gcc/c-pragma.c:238: warning: unused variable `name'
../../egcs-CVS19990913/gcc/genrecog.c: In function `make_insn_sequence':
../../egcs-CVS19990913/gcc/genrecog.c:229: warning: passing arg 1 of
	`bzero' from incompatible pointer type
../../egcs-CVS19990913/gcc/jump.c:5460: warning:
	`find_insert_position' defined but not used
../../egcs-CVS19990913/gcc/mips-tdump.c:62: warning: `fatal' defined
	but not used
../../egcs-CVS19990913/gcc/recog.c: In function `preprocess_constraints':
../../egcs-CVS19990913/gcc/recog.c:2065: warning: passing arg 1 of
	`bzero' from incompatible pointer type
../../egcs-CVS19990913/gcc/tree.c: In function `tree_cons':
../../egcs-CVS19990913/gcc/tree.c:2049: warning: passing arg 1 of
	`bzero' from incompatible pointer type
../../egcs-CVS19990913/gcc/varasm.c: At top level:
../../egcs-CVS19990913/gcc/varasm.c:4450: warning:
	`remove_from_pending_weak_list' defined but not used





Index: ChangeLog
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/ChangeLog,v
retrieving revision 1.4389
diff -u -p -r1.4389 ChangeLog
--- ChangeLog	1999/09/14 16:27:23	1.4389
+++ ChangeLog	1999/09/14 18:15:15
@@ -1,3 +1,30 @@
+Tue Sep 14 14:14:28 1999  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
+
+	* c-pragma.c (handle_pragma_token): Wrap variables `name' and
+	`value' in HANDLE_PRAGMA_WEAK.  Wrap variable `align' in
+	HANDLE_PRAGMA_PACK||HANDLE_PRAGMA_PACK_PUSH_POP.
+
+	* genrecog.c (make_insn_sequence): Call memset, not bzero.
+
+	* jump.c (find_insert_position): Don't declare or define unless
+	!HAVE_conditional_arithmetic.
+	(returnjump_p_1, delete_prior_computation): Add static prototypes.
+
+	* mips-tdump.c (fatal, fancy_abort, main): Add extern prototypes.
+	
+	* recog.c (offsettable_address_p): Prototype function pointer.
+	(preprocess_constraints): Call memset, not bzero.
+	
+	* tree.c (tree_node_kind_names): Constify a char*.  Make static.
+	(gcc_obstack_init): Don't declare.
+	(fix_sizetype): Add static prototype.
+	(gcc_obstack_init): Use prototype casts in call to _obstack_begin.
+	(tree_cons): Call memset, not bzero.
+
+	* varasm.c (remove_from_pending_weak_list): Wrap declaration and
+	definition in macro ASM_WEAKEN_LABEL.
+	(mark_const_hash_entry): Add static prototype.
+
 Tue Sep 14 12:22:50 1999  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 
 	* c-lex.c (handle_generic_pragma): Remove unused variable `c'.
Index: c-pragma.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/c-pragma.c,v
retrieving revision 1.20
diff -u -p -r1.20 c-pragma.c
--- c-pragma.c	1999/09/09 04:00:35	1.20
+++ c-pragma.c	1999/09/14 18:15:15
@@ -235,9 +235,13 @@ handle_pragma_token (string, token)
 {
   static enum pragma_state state = ps_start;
   static enum pragma_state type;
+#ifdef HANDLE_PRAGMA_WEAK
   static char * name;
   static char * value;
+#endif
+#if defined(HANDLE_PRAGMA_PACK) || defined(HANDLE_PRAGMA_PACK_PUSH_POP)
   static int align;
+#endif
   static tree id;
 
   /* If we have reached the end of the #pragma directive then
Index: genrecog.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/genrecog.c,v
retrieving revision 1.46
diff -u -p -r1.46 genrecog.c
--- genrecog.c	1999/09/12 12:45:28	1.46
+++ genrecog.c	1999/09/14 18:15:16
@@ -225,8 +225,8 @@ make_insn_sequence (insn, type)
 	int new_size;
 	new_size = (insn_name_ptr_size ? insn_name_ptr_size * 2 : 512);
 	insn_name_ptr = xrealloc (insn_name_ptr, sizeof(char *) * new_size);
-	bzero (insn_name_ptr + insn_name_ptr_size,
-	       sizeof(char *) * (new_size - insn_name_ptr_size));
+	memset (insn_name_ptr + insn_name_ptr_size, 0,
+		sizeof(char *) * (new_size - insn_name_ptr_size));
 	insn_name_ptr_size = new_size;
       }
 
Index: jump.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/jump.c,v
retrieving revision 1.75
diff -u -p -r1.75 jump.c
--- jump.c	1999/09/07 05:47:56	1.75
+++ jump.c	1999/09/14 18:15:20
@@ -124,9 +124,11 @@ static int delete_labelref_insn		PROTO((
 static void mark_modified_reg		PROTO((rtx, rtx));
 static void redirect_tablejump		PROTO((rtx, rtx));
 static void jump_optimize_1		PROTO ((rtx, int, int, int, int));
-#ifndef HAVE_cc0
+#if ! defined(HAVE_cc0) && ! defined(HAVE_conditional_arithmetic)
 static rtx find_insert_position         PROTO((rtx, rtx));
 #endif
+static int returnjump_p_1	        PROTO((rtx *, void *));
+static void delete_prior_computation    PROTO((rtx, rtx));
 
 /* Main external entry point into the jump optimizer.  See comments before
    jump_optimize_1 for descriptions of the arguments.  */
@@ -5450,7 +5452,7 @@ rtx_equal_for_thread_p (x, y, yinsn)
 }
 
 
-#ifndef HAVE_cc0
+#if !defined(HAVE_cc0) && !defined(HAVE_conditional_arithmetic)
 /* Return the insn that NEW can be safely inserted in front of starting at
    the jump insn INSN.  Return 0 if it is not safe to do this jump
    optimization.  Note that NEW must contain a single set. */
Index: mips-tdump.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/mips-tdump.c,v
retrieving revision 1.13
diff -u -p -r1.13 mips-tdump.c
--- mips-tdump.c	1999/09/08 19:42:01	1.13
+++ mips-tdump.c	1999/09/14 18:15:21
@@ -56,8 +56,10 @@ typedef const PTR_T CPTR_T;
 #define uint	unsigned int
 #define ulong	unsigned long
 
-
-static void
+void fatal PROTO ((const char *)) ATTRIBUTE_NORETURN;
+void fancy_abort PROTO ((void)) ATTRIBUTE_NORETURN;
+  
+void
 fatal(s)
   const char *s;
 {
@@ -1438,6 +1440,8 @@ read_tfile __proto((void))
 }
 
 
+
+extern int main PROTO ((int, char **));
 
 int
 main (argc, argv)
Index: recog.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/recog.c,v
retrieving revision 1.41
diff -u -p -r1.41 recog.c
--- recog.c	1999/09/12 12:45:33	1.41
+++ recog.c	1999/09/14 18:15:23
@@ -1828,7 +1828,8 @@ offsettable_address_p (strictp, mode, y)
   register rtx z;
   rtx y1 = y;
   rtx *y2;
-  int (*addressp) () = (strictp ? strict_memory_address_p : memory_address_p);
+  int (*addressp) PROTO ((enum machine_mode, rtx)) =
+    (strictp ? strict_memory_address_p : memory_address_p);
 
   if (CONSTANT_ADDRESS_P (y))
     return 1;
@@ -2062,7 +2063,7 @@ preprocess_constraints ()
 {
   int i;
 
-  bzero (recog_op_alt, sizeof recog_op_alt);
+  memset (recog_op_alt, 0, sizeof recog_op_alt);
   for (i = 0; i < recog_data.n_operands; i++)
     {
       int j;
Index: tree.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/tree.c,v
retrieving revision 1.89
diff -u -p -r1.89 tree.c
--- tree.c	1999/09/13 07:41:20	1.89
+++ tree.c	1999/09/14 18:15:24
@@ -209,7 +209,7 @@ int tree_node_counts[(int)all_kinds];
 int tree_node_sizes[(int)all_kinds];
 int id_string_size = 0;
 
-const char *tree_node_kind_names[] = {
+static const char * const tree_node_kind_names[] = {
   "decls",
   "types",
   "blocks",
@@ -272,9 +272,8 @@ static void set_type_quals PROTO((tree, 
 static void append_random_chars PROTO((char *));
 static void build_real_from_int_cst_1 PROTO((PTR));
 static void mark_type_hash PROTO ((void *));
+static void fix_sizetype PROTO ((tree));
 
-void gcc_obstack_init ();
-
 /* If non-null, a language specific helper for unsave_expr_now. */
 
 void (*lang_unsave_expr_now) PROTO((tree));
@@ -332,8 +331,8 @@ gcc_obstack_init (obstack)
 #define OBSTACK_CHUNK_FREE free
 #endif
   _obstack_begin (obstack, OBSTACK_CHUNK_SIZE, 0,
-		  (void *(*) ()) OBSTACK_CHUNK_ALLOC,
-		  (void (*) ()) OBSTACK_CHUNK_FREE);
+		  (void *(*) PROTO ((long))) OBSTACK_CHUNK_ALLOC,
+		  (void (*) PROTO ((void *))) OBSTACK_CHUNK_FREE);
 }
 
 /* Save all variables describing the current status into the structure
@@ -2046,7 +2045,7 @@ tree_cons (purpose, value, chain)
   else
     {
       node = (tree) obstack_alloc (current_obstack, sizeof (struct tree_list));
-      bzero (node, sizeof (struct tree_common));
+      memset (node, 0, sizeof (struct tree_common));
     }
 
 #ifdef GATHER_STATISTICS
Index: varasm.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/varasm.c,v
retrieving revision 1.79
diff -u -p -r1.79 varasm.c
--- varasm.c	1999/09/09 18:55:37	1.79
+++ varasm.c	1999/09/14 18:15:25
@@ -177,7 +177,9 @@ static void mark_constants		PROTO((rtx))
 static int output_addressed_constants	PROTO((tree));
 static void output_after_function_constants PROTO((void));
 static void output_constructor		PROTO((tree, int));
+#ifdef ASM_WEAKEN_LABEL
 static void remove_from_pending_weak_list	PROTO ((char *));
+#endif
 #ifdef ASM_OUTPUT_BSS
 static void asm_output_bss		PROTO((FILE *, tree, char *, int, int));
 #endif
@@ -188,6 +190,7 @@ static void asm_output_aligned_bss	PROTO
 #endif /* BSS_SECTION_ASM_OP */
 static void mark_pool_constant          PROTO((struct pool_constant *));
 static void mark_pool_sym_hash_table	PROTO((struct pool_sym **));
+static void mark_const_hash_entry	PROTO((void *));
 
 static enum in_section { no_section, in_text, in_data, in_named
 #ifdef BSS_SECTION_ASM_OP
@@ -4445,6 +4448,7 @@ weak_finish ()
 /* Remove NAME from the pending list of weak symbols.  This prevents
    the compiler from emitting multiple .weak directives which confuses
    some assemblers.  */
+#ifdef ASM_WEAKEN_LABEL
 static void
 remove_from_pending_weak_list (name)
      char *name ATTRIBUTE_UNUSED;
@@ -4461,6 +4465,7 @@ remove_from_pending_weak_list (name)
     }
 #endif
 }
+#endif
 
 void
 assemble_alias (decl, target)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]