This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Patch: Add TOUPPER/TOLOWER to system.h and clean up ctype stuff
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Patch: Add TOUPPER/TOLOWER to system.h and clean up ctype stuff
- From: Gavin Romig-Koch <gavin at cygnus dot com>
- Date: Tue, 14 Sep 1999 11:15:41 -0400 (EDT)
- Cc: egcs-patches at egcs dot cygnus dot com
- References: <199909130410.AAA02667@enzo.rutgers.edu>
Kaveh R. Ghazi writes:
> 1999-09-10 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> * c-lex.c (yyerror): Cast the argument of a ctype function to
> `unsigned char' and/or use uppercase ctype macro from system.h.
The c-lex.c part is OK (the rest looks fine to me too, but I can't
approve it).
I like to see the cast to (unsigned char) moved into the ISXXX macros
if that's do-able without breaking anything. Failing that, I think it
would be good to have a comment in system.h explaining when and why
we have to cast the arguments to the ISXXX macros to (unsigned char).
-gavin...