This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Prototype make_temp_file


 > From: Gavin Romig-Koch <gavin@cygnus.com>
 >  
 > Marc Espie writes:
 >  > In article <19990908125140.A19576@schutzenberger.liafa.jussieu.fr> I wrote:
 >  > >This patch moves the make_temp_file prototype to a central location.
 >  > >I don't have any mips system, but I don't think removing that cruft
 >  > >will break anything.
 >  > 
 >  > Sure enough, I was too quick.
 >  > 
 >  > Here is a revised diff for mips.c
 >  
 > If the liberty change is acceptable, the mips change is OK except
 > for some minor problems.
 >  
 > Unless someone can say that MSDOS's unlink now behaves like 
 > Unix's unlink, I think we still need the ifndef's around the
 > unlink in mips.c.
 >  
 > Also the ChangeLog entry should, I think, mention the change to
 > mips_asm_file_start.
 >  
 >                                            -gavin...


I posted an almost identical patch less than two weeks ago.

http://egcs.cygnus.com/ml/gcc-patches/1999-08/msg00995.html

The only difference is that I renamed the mips.c function to
mips_make_temp_file rather than removing it (because of its different
behavior, it seemed safer.)

Depending on whether Gavin is happy with using the libiberty copy, I
am happy with either version of the patch.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Qwest Internet Solutions


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]