This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch to constify/prototype/clean collect2.[ch] & tlink.c, part 1/2
- To: law at cygnus dot com
- Subject: Re: Patch to constify/prototype/clean collect2.[ch] & tlink.c, part 1/2
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Fri, 3 Sep 1999 09:31:11 -0400 (EDT)
- Cc: egcs-patches at egcs dot cygnus dot com, jason at cygnus dot com
> From: Jeffrey A Law <law@cygnus.com>
> >
> > If you let me know your preference, I will rewrite the patch
> > accordingly and resubmit.
>
> None of these really sound like good enough reasons to start
> duplicating stuff.
>
> When we started the warning removal process we agreed that there
> would be some cases that it would not be practical to fix. I think
> this kind of stuff falls into that category.
>
> In fact, I think the duping of strings to avoid this kind of
> problem just makes the code more difficult to read and understand
> than it needs to be.
>
> Please let's not get overly pedantic about killing warnings.
> Particularly those not triggered by -Wall.
>
> jeff
Okay, you have indicated your preference. :-) I will rewrite
the patch accordingly and resubmit.
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions