This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Warnings removal
- To: Marc dot Espie at liafa dot jussieu dot fr, egcs-patches at egcs dot cygnus dot com
- Subject: Re: Warnings removal
- From: Richard Henderson <rth at cygnus dot com>
- Date: Tue, 31 Aug 1999 22:07:43 -0700
- References: <19990831192733.A27630@tetto.liafa.jussieu.fr>
On Tue, Aug 31, 1999 at 07:27:33PM +0200, Marc Espie wrote:
> Mostly a no-brainer, just add prototypes and constify a few
> char * to remove warnings.
Zack did all this last Thursday.
> I believe that most of the declarations in libgcc2.c should be
> digged out of the #ifdef where they live.
> Right now, that mammoth file defines lots of functions, but there
> is no cross-checking, like __terminate proves.
I would accept a patch for that. Just putting __terminate
somewhere seems haphazard.
> * final.c (output_addr_const): Replace fprintf with fputs.
As does this. There's plenty of other silly calls to fprintf
in the same area -- why didn't you change them too?
> * alias.c (non_local_reference_p): Constify.
Applied.
r~