Re: [PATCH] Remove warning cleanups

[Jeffrey A Law <law@cygnus.com>]

  In message <19990407172743.A9424@localhost.neosoft.com>you write:
  > Hi.
  > 
  > Here are two more patches which get rid of warnings seen in
  > the latest snapshot.
  > 
  > The first is for 'cccp.c' - the warnings are comparing signed
  > and unsigned values. To my (untrained) eye, the check performed
  > by the code seems silly, so removing the check removes the warnings.
  > Maybe I'm missing something obvious...
Think about overflow and sign/zero extensions.  For better or worse size_t is
not always an unsigned type and it's not always the same as the st_size field
within a stat_buf.

  > The second patch is for 'final.c' - on i386, the ASM_OPEN_PAREN
  > and ASM_CLOSE_PAREN are "", while every other platform I could
  > find they are "(" and ")". Assuming the macro as it stands
  > is correct, this fix gets rid of a zero-length format string
  > warning.
Thanks.  I've installed this patch.


  > Do patches this small require a ChangeLog entry? I'll resubmit
  > with one if desired.
Yes.  No need to resubmit. I went ahead and generated a ChangeLog entry for
the patch I installed.
jeff