This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the EGCS project.
Re: -fpic on powerpc is still not quite right.
- To: Geoff Keating <geoffk@ozemail.com.au>
- Subject: Re: -fpic on powerpc is still not quite right.
- From: Jeffrey A Law <law@cygnus.com>
- Date: Mon, 02 Aug 1999 01:03:22 -0600
- cc: egcs-patches@egcs.cygnus.com
- Reply-To: law@cygnus.com
In message <199907171216.WAA01564@geoffk.wattle.id.au>you write:
> ===File ~/patches/egcs-13.diff==============================
> Fri Jul 16 23:43:36 1999 <geoffk@cygnus.com>
>
> * config/rs6000/rs6000.c (rs6000_stack_info): Don't allow reload
> to change the stack frame configuration.
A couple comments.
First, I believe this code belongs in first_reg_to_save. That is where other
similar issues are handled for aix (like profiling stuff). Furthermore, it
just makes sense given the name "first_reg_to_save" -- that's precisely what
it should return. Having it return the first reg to save, except for this
weird case is kind of dumb.
> + if (flag_pic == 1
Shouldn't this be "flag_pic" or "flag_pic != 0? Remember flag_pic can take on
multiple values, 0 (default), 1 (-fpic), or 2 (-fPIC). Or is flag_pic's
meaning different on the PPC port?
jeff