This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Request for comments
- To: Richard Henderson <rth at cygnus dot com>
- Subject: Re: PATCH: Request for comments
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Mon, 28 Jun 1999 08:40:37 -0600
- cc: egcs-patches at egcs dot cygnus dot com
- Reply-To: law at cygnus dot com
In message <19990625122926.I23285@cygnus.com>you write:
> On Fri, Jun 25, 1999 at 10:12:57AM -0600, Jeffrey A Law wrote:
> > + new_x = gen_reg_rtx (Pmode);
> > + new_y = gen_reg_rtx (Pmode);
> > + new_size = gen_reg_rtx (TYPE_MODE (sizetype));
> > + emit_move_insn (new_x, force_operand (XEXP (x, 0), NULL_RTX));
> > + emit_move_insn (new_y, force_operand (XEXP (y, 0), NULL_RTX));
> > + emit_move_insn (new_size, force_operand (new_size, NULL_RTX));
>
> These pairs are copy_to_mode_reg.
Fixed.
[ fixing bcopy ]
> > Either it should use the same code for simplicity or we need a comment
> > for this case.
I did both :-) We'll now copy the values into fresh pseudos before calling
emit_library_call too.
As I mentioned, clear_storage has the same bug (and is majorly mis-indented).
I've just installed a testcase for this bug into the mainline testsuite. A
new patch to fix the bug will be available soon (after I'm finished testing
it).
jeff