This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Fix 2 PPC/SYSV varargs problems
- To: Franz Sirl <Franz dot Sirl-kernel at lauterbach dot com>
- Subject: Re: PATCH: Fix 2 PPC/SYSV varargs problems
- From: Richard Henderson <rth at cygnus dot com>
- Date: Sun, 27 Jun 1999 13:03:18 -0700
- Cc: egcs-patches at egcs dot cygnus dot com, meissner at cygnus dot com, David Edelsohn <dje at watson dot ibm dot com>, "Jeffrey A. Law" <law at cygnus dot com>
- References: <19990626210219.A532@cygnus.com> <99062713572400.00601@ns1102.munich.netsurf.de>
On Sun, Jun 27, 1999 at 12:59:34PM +0200, Franz Sirl wrote:
> Hmm, I think you missed one purpose of this change. What happens if
> one or more integer register are used for varargs passing, but 9 or
> more floats are earlier in the argument list?
Ah yes. This did slip my mind.
We should just be implementing the algortithm exactly
as presented in the ABI manual. It's clear enough.
> Somehow the use of overflow_arg_area for integer or float
> overflow arguments has to be recorded separately.
Actually, the _overflow_ needs to be recorded together. It's
the registers that need to be separate.
> Since you seem to say that words counting is correct as-is, we
> probably have to go back to my 1st version of this patch with
> all the (words - sysv_ovf_fwords) constructs in there and words
> and sysv_ovf_fwords incremented simultaneously.
I think that's just confusing, using two variables to try
to record three values.
I'll give you another patch in a little bit.
r~