This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fixincl.c uses non-portable #error and string concatenation
- To: Alexandre Oliva <oliva at dcc dot unicamp dot br>
- Subject: Re: fixincl.c uses non-portable #error and string concatenation
- From: Jeffrey A Law <law at upchuck dot cygnus dot com>
- Date: Mon, 17 May 1999 23:59:26 -0600
- cc: egcs-patches at egcs dot cygnus dot com, Bruce Korb <ddsinc09 at ix dot netcom dot com>
- Reply-To: law at cygnus dot com
In message <orso8vwb13.fsf@lua.lbi.dcc.unicamp.br>you write:
> I was trying to get the C fixincl to run on a poor SPARCstation
> running StunOS 4.1.3, when using cc as the bootstrap compiler. The
> first problem is that cc doesn't support the `#error' directive; fixed
> in the attached patch. Ok to install?
Thanks. I hadn't gotten around to doing any stunos tests yet :-)
> The second problem is that cc does not support concatenation of
> adjacent strings, and not only inclhack.def seems to assume this is
> possible, but also fixincl.tpl uses `"|"' strings to separate
> filenames.
>
> We could remove the explicit adjacent strings from inclhack.def, but
> fixincl.tpl would have to be modified somehow in order to generate a
> single string even for multiple files, instead of multiple adjacent
> strings. Bruce, how can we achieve this with AutoGen? Couldn't we
> use AutoGen to merge adjacent strings in inclhack.def too?
>
Ew. Yup, we need to fix these.
> Index: gcc/ChangeLog
> from Alexandre Oliva <oliva@dcc.unicamp.br>
>
> * fixinc/fixincl.c: Remove #error, it is not portable.
I went ahead and installed this. No sense in making it wait if there's
issues with your patch to deal with all the issues you raised in this
message.
jeff