This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Patch for loop unroll bug



  In message <3735B304.4283@rcp.co.uk>you write:
  > Here's a corrected patch and ChangeLog entry against
  > the egcs-19990502 snapshot.
  > 
  > Graham
  > 
  > ChangeLog
  > 
  >         * loop.c maybe_eliminate_biv(): check regno against
  >         max_reg_before_loop to correct a --enable-checking
  >         failure when compiling gcc/f/target.c
  > 
Installed.  Also note that your mailer seems to be converting tabs into
spaces in addition to wrapping long lines.  This makes your patches
difficult to apply.

The ChangeLog entry needed some work too.  A ChangeLog entry should only note
the change, not the reason behind the change.  If you want/need to identify
why a change was made you should do so as comments in the code itself since
that's what people are more likely to examine in the future if something
goes wrong.

Thanks,
jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]