This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Interix, batch II.
- To: Donn Terry <donn at interix dot com>
- Subject: Re: Interix, batch II.
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sat, 03 Apr 1999 13:54:07 -0700
- cc: "egcs-patches at cygnus dot com" <egcs-patches at cygnus dot com>
- Reply-To: law at cygnus dot com
In message <36F977F6.93ABCF2A@interix.com>you write:
> Fri Feb 12 22:27:02 1999 Donn Terry (donn@interix.com)
> * config/i386/t-interix: use mostly system headers unchanged.
> Use system assert.h
> * fixinc.interix: ditto (make almost no-op).
> * config/x-interix.h: build with _ALL_SOURCE
> * config/xm-interix.h: ONLY_INT_FIELDS only when bootstrapping.
> * config/i386/xm-i386-interix.h: new file
> * config/i386: rename interix.h->i386-interix.h
> * gcc/configure: Use the new files.
Can you please follow GNU conventions for the ChangeLog? When you fail to do
so I have to rewrite it, which is time consuming.
Capitolize the start of each entry; include a period at the end of each entry.
The format is
* file (function, macro, or variable): What changed.
You changed gcc/configure.in, not gcc/configure. The ChangeLog for that should
look like:
* configure.in (interix): Use new files.
* configure: Rebuilt.
> --- egcs.source.old/gcc/config/i386/interix.h Sun Jan 31 08:14:46 199
> 9
> +++ egcs.source/gcc/config/i386/interix.h Fri Feb 5 13:03:04 1999
> @@ -157,10 +157,10 @@
> register unsigned char *_limited_str = (unsigned char *) (STR);
> \
> register unsigned ch;
> \
> fprintf ((FILE), "\t%s\t\"", STRING_ASM_OP); \
> - for (; ch = *_limited_str; _limited_str++) \
> + for (; (ch = *_limited_str); _limited_str++) \
> { \
> - register int escape; \
> - switch (escape = ESCAPES[ch]) \
> + register int escape = ESCAPES[ch]; \
> + switch (escape) \
> { \
> case 0: \
> putc (ch, (FILE)); \
This change is not mentioned anywhere in your ChangeLog entry. You need to
fix that.
> diff -urP egcs.source.old/gcc/config/i386/xm-i386-interix.h egcs.source/gcc
> /config/i386/xm-i386-interix.h
> --- egcs.source.old/gcc/config/i386/xm-i386-interix.h Wed Dec 31 17:0
> 0:00 1969
> +++ egcs.source/gcc/config/i386/xm-i386-interix.h Fri Feb 5 13:41:45 199
> 9
> @@ -0,0 +1,33 @@
> +/* Configuration for GNU compiler
> + for an Intel i386 or later processor running Windows NT 3.x.
> + Copyright (C) 1994 Free Software Foundation, Inc.
> + Contributed by Douglas B. Rupp (drupp@cs.washington.edu)
You need to update this comment and the copyright date for the new file
since the old comment does not apply for the new file.
> diff -urP egcs.source.old/gcc/fixinc.interix egcs.source/gcc/fixinc.interix
> --- egcs.source.old/gcc/fixinc.interix Sun Jan 31 08:15:54 1999
> +++ egcs.source/gcc/fixinc.interix Fri Feb 5 13:03:05 1999
> @@ -1,4 +1,6 @@
> #!/bin/sh
> +rm -f include/stddef.h
> +exit
> #
> # fixinc.interix -- Install modified versions of Interix system includ
> e
> # files.
The right file to change is fixinc/fixinc.interix.
I believe the new files and file rename will cause problems on 8.3 filesystems
(which unfortunately we do have to support) since I think the new filenames
you have added will conflict with existing filenames.
There is a utility (doschk.c) in the gcc subdirectory to walk over a directory
tree and indicate what files conflict with each other in an 8.3 filesystem. I
suggest you find it and use it to verify that you do not introduce any new
conflicts. The patch can not go in until we know it's not adding new conflicts.
With those issues resolved this patch will be fine.
jeff