This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A patch to constify gcc.c (Really, summarizing remaining warnings)
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>, law at cygnus dot com, zack at rabi dot columbia dot edu
- Subject: Re: A patch to constify gcc.c (Really, summarizing remaining warnings)
- From: Richard Henderson <rth at cygnus dot com>
- Date: Sun, 14 Mar 1999 09:23:43 -0800
- Cc: egcs-patches at cygnus dot com
- References: <199903141228.HAA07825@caip.rutgers.edu>
On Sun, Mar 14, 1999 at 07:28:00AM -0500, Kaveh R. Ghazi wrote:
> However, gotos and jmp stuff make my head hurt, so please
> examine this with a careful eye to make sure I got everything right. :-)
> (I did a successful bootstrap on Irix6.)
It looks correct.
> Note, I made one change to the original do_float_handler you
> posted which was to call set_float_handler(NULL) in the case where
> setjmp returned a value > 0. This makes sure all exit points of
> do_float_handler reset the handler back to zero.
If you examine the signal handler where longjmp is called, you'll
see that it (in effect) resets the handler there.
Actually, if all this was cleaned up so that set_float_handler was
not called from anywhere but do_float_handler, some of this could
definitely be cleaned up a tad. So I'd not worry about your extra
change until then.
> Is this okay to install?
Yes.
r~