This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A Linux/ARM patch for egcs 1.1.2
- To: hjl at lucon dot org
- Subject: Re: A Linux/ARM patch for egcs 1.1.2
- From: Jeffrey A Law <law at hurl dot cygnus dot com>
- Date: Sat, 27 Feb 1999 20:04:57 -0700
- cc: Philip Blundell <pb at nexus dot co dot uk>, egcs-patches at egcs dot cygnus dot com
- Reply-To: law at cygnus dot com
In message <E10GKJw-0004iR-00@fountain.nexus.co.uk> Philip wrote:
> >This patch will support Linux/ARM in egcs 1.1.2. If it is accepted,
> >I will work on the Linux/MIPS patch for egcs 1.1.2.
>
> I don't think this is a good idea. It has a high chance of breaking
> previously-working ARM targets. To be honest I would prefer to keep
> Linux/ARM as a separate patch for egcs 1.1 and spend the time on
> integrating it into the mainline for egcs 1.2.
HJ, thanks.
Based on Philip's comments and my own quick scan of the change, I don't think
we want this patch for egcs-1.1.2.
The major problems I see are:
* Modifies shared files, flow.c, reload.c, crtstuff and possibly
others.
* Heavily modifes ARM shared files arm.c, arm.h, arm.md.
Modifying a shared file does not strictly mean a patch is going to be rejected
for the release branch. However this patch heavily modifies the ARM port, and
I am not comfortable with such a patch for the release branch.
I have no idea if the MIPS patch suffers from the same problems as the ARM
patch or not. If you don't submit the patch we will never know. Then again,
if you know it suffers from the same problems, then there's no point in
submitting the patch.
Jeff