This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: quoting fix for arm


Well spotted Craig.

Mike, this is ok once that "nit" is fixed.

Richard.
 
> Nit below, which might indicate a bug in the new code:
> 
> >1999-02-24  Mike Stump  <mrs@wrs.com>
> >
> >	* arm/aout.h (DBX_OUTPUT_MAIN_SOURCE_FILENAME): Fix quoting.
> >
> >Doing diffs in config/arm/aout.h.~1~:
> >*** config/arm/aout.h.~1~	Thu Nov  5 14:35:52 1998
> >--- config/arm/aout.h	Wed Feb 24 20:16:51 1999
> >*************** Boston, MA 02111-1307, USA.  */
> >*** 118,124 ****
> >     ``desc'' field is set to compiler version number >= 315 (sic).  */
> >  #define DBX_OUTPUT_MAIN_SOURCE_FILENAME(STREAM,NAME) 			\
> >  do {									\
> >!   fprintf (STREAM, ".stabs \"%s\",%d,0,315,%s\n", (NAME), N_SO,		\
> >  	   &ltext_label_name[1]);					\
> >    text_section ();							\
> >    ASM_OUTPUT_INTERNAL_LABEL (STREAM, "Ltext", 0);			\
> >--- 118,126 ----
> >     ``desc'' field is set to compiler version number >= 315 (sic).  */
> >  #define DBX_OUTPUT_MAIN_SOURCE_FILENAME(STREAM,NAME) 			\
> >  do {									\
> >!   fprintf (STREAM, ".stabs ");						\
> >!   output_quoted_string (STREAM, NAME);					\
> >!   fprintf (STREAM, ",%d,0,315,%s\n", (NAME), N_SO,			\
> >  	   &ltext_label_name[1]);					\
> >    text_section ();							\
> >    ASM_OUTPUT_INTERNAL_LABEL (STREAM, "Ltext", 0);			\
> >--------------
> 
> Shouldn't the `(NAME)' argument be removed from the second `printf'?
> 
>         tq vm, (burley)




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]