This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: multiple definitions of 'xxx keyed to...' in egcs-1.1.1


>>>>> Jeffrey A Law <law@hurl.cygnus.com> writes:

 >   In message <u9vhgvfmfa.fsf@yorick.cygnus.com>you write:
 >> This is wrong, or at least incomplete.  ASM_OUTPUT_CONSTRUCTOR does not
 >> imply the use of .ctors/.dtors sections.

 > Right.  That's why trying to fix this problem by depending on that macro
 > is wrong.

 > It sounds like we need a new macro which indicates the target uses
 > ctor/dtor sections and the dynamic linker handles firing of ctors/dtors.
 > Given such a macro, we can safely make these functions static on those
 > systems where it is safe.

I think ASM_OUTPUT_CONSTRUCTOR can be that macro, if we change the
documentation; it looks like the aoutos.h version was the only one that
would break with HJ's patch.  All the definitions for COFF and such
targets looked fine; they also rely on the value of the symbol within the
translation unit rather than having it available to the linker.  We only
need the symbols to be public if we're using collect.

Having another macro would also be fine, and would allow for runtime
selection.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]