This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: flow reorg patch
- To: Richard Henderson <rth at cygnus dot com>
- Subject: Re: flow reorg patch
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sun, 31 Jan 1999 18:16:24 -0700
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <19990125194333.E1456@dot.cygnus.com>you write:
> Yeah, that was just a quick fix since I've not yet written
> insert_insn_on_edge. Previously I'd been running flow2 after
> thread_p_e so this hadn't been an issue. But I'd backed that
> out so that we wouldn't have quite so many target-specific
> issues to deal with.
>
> The correct thing to do is to insert those instructions on the
> edge between ENTRY_BLOCK and block 1, and similarly for the exit.
In the case where they do not make a block unto themselves we can simply
add them to the ENTRY/EXIT blocks. When the prologue/epilouge make a block
unto themselves it's more complicated since we really need to create one or
more new blocks.
However, I believe that is the exception rather than the rule. Simply adding
them to the appropriate block should work most of the time.
> I've not yet incorporated that code. There are other things I'd like
> to do wrt EH -- I may have sent that note just to Andrew but I didn't
> think so -- and I thought I'd take care of that all at once after the
> bulk of this is delt with.
You need to incorporate it since the newer code is already in egcs. You'd
take the code a step backwards if you don't incorporate it.
jeff