This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libiberty as a parameter
- To: Marc Espie <Marc dot Espie at liafa dot jussieu dot fr>
- Subject: Re: libiberty as a parameter
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sun, 31 Jan 1999 12:41:40 -0700
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <19990131165846.41336@liafa1.liafa.jussieu.fr>you write:
> I'll admit this is a weird patch, as it does not do anything yet.
>
> The idea is just to make explicit the ../libiberty/libiberty.a
> as a variable in gcc/Makefile.in, so that a further stage command
> could override it by passing explicitly LIBIBERTY=... to the sub-make.
>
> In a less abstract way, OpenBSD does have a dynamic library flavor of
> libiberty already installed when gcc/egcs gets built. So specifying
> LIBIBERTY=-liberty along is enough to pick it up.
>
> Sun Jan 31 16:57:41 MET 1999 Marc Espie (espie@openbsd.org)
> * Makefile.in: introduce LIBIBERTY as an overridable variable
This is an extremely bad idea.
You're making the assumption that your libiberty is always going to be 100%
compatible with the one included in egcs. Since libiberty continues to evolve
and change it's often not going to be compatible from release to release.
I will not accept any patches to override the libiberty we include with egcs
with one provided by the system.
We'll probably end up with libiberty being a variable at some point (if/when
we built multiple versions to deal with multiple abis on the build host), but
until then I think this kind of patch is a mistake.
Jeff