Re: PATCH: egcs_update problem

[Gerald Pfeifer <pfeifer at dbai dot tuwien dot ac dot at>]

On Tue, 19 Jan 1999, Zack Weinberg wrote:
> I am much more worried about other problems in egcs_update - variable
> overflow, backquotes inside backquotes, loop inside backquotes, &&
> used perl-style, set --.  Also the ordering in the final for-loop
> looks suspicious to me, with generated .y files touched after their
> corresponding .c files.

Zack, 

how about the following patch? (FWIW, the && used perl-style was not
introduced by myself.)

I also noticed that we seem to have been inconsistent in touching the
*.y files in the for loop. Hmm...

Gerald


Index: egcs_update
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/contrib/egcs_update,v
retrieving revision 1.12
diff -c -3 -p -r1.12 egcs_update
*** egcs_update	1999/01/19 12:10:12	1.12
--- egcs_update	1999/01/20 20:00:45
*************** echo "Pass 1: Updating autoconf and biso
*** 52,59 ****
  # makes sense to drop into the tree, but it isn't CVS-controlled.
  X=`for i in \`find . -name configure.in -o -name '*.y'\`
  do
! 	D=\`dirname $i\`/CVS
! 	[ -f $i -a  -d $D ]  && echo $i
  done`
  cvs -q update $X
  
--- 52,61 ----
  # makes sense to drop into the tree, but it isn't CVS-controlled.
  X=`for i in \`find . -name configure.in -o -name '*.y'\`
  do
!     D=\`dirname $i\`/CVS
!     if [ -f $i -a -d $D ]; then 
!         echo $i
!     fi
  done`
  cvs -q update $X
  
*************** touch `find texinfo -name Makefile.in -p
*** 69,83 ****
  touch `find texinfo -name \*.pot -print`
  touch `find texinfo -name \*.gmo -print`
  for f in gcc/c-parse.y \
  	 gcc/cstamp-h.in \
  	 gcc/c-gperf.h \
- 	 gcc/c-parse.c \
- 	 gcc/c-parse.h \
  	 gcc/cexp.c \
  	 gcc/cp/parse.c \
  	 gcc/cp/parse.h \
- 	 gcc/objc/objc-parse.c \
  	 gcc/objc/objc-parse.y \
  	 gcc/java/parse.h \
  	 gcc/java/parse.c \
  	 gcc/java/parse-scan.c \
--- 71,85 ----
  touch `find texinfo -name \*.pot -print`
  touch `find texinfo -name \*.gmo -print`
  for f in gcc/c-parse.y \
+ 	 gcc/c-parse.h \
+ 	 gcc/c-parse.c \
  	 gcc/cstamp-h.in \
  	 gcc/c-gperf.h \
  	 gcc/cexp.c \
  	 gcc/cp/parse.c \
  	 gcc/cp/parse.h \
  	 gcc/objc/objc-parse.y \
+ 	 gcc/objc/objc-parse.c \
  	 gcc/java/parse.h \
  	 gcc/java/parse.c \
  	 gcc/java/parse-scan.c \