This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: CVS-19981231: PATCH for incorrect label refs on i586-linux
- To: manfred at s-direktnet dot de, Manfred dot Hollstein at ks dot sel dot alcatel dot de
- Subject: Re: CVS-19981231: PATCH for incorrect label refs on i586-linux
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Fri, 01 Jan 1999 11:36:06 -0700
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <13963.32077.675682.338951@saturn.hollstein.net>you write:
> Jeff, your recent change
>
> Wed Dec 30 23:38:55 1998 Jeffrey A Law (law@cygnus.com)
>
> * i386.md (doubleword shifts): Avoid namespace pollution.
Shit. I know I bootstrapped that change. Oh well, it's wrong, even if some
assembler did accept the colons.
> label ref for the "je" instruction (which emits a label *definition*),
> while it should have been a call sequence of
> ASM_GENERATE_INTERNAL_LABEL and assemble_name.
>
> OK to install?
Nope. Your patch loses too. It'll put a '*' at the front of the label on
some ports which causes problems. See config/svr4.h. That's precisely why
I'm not using that code to begin with.
Argggh!
I wonder if %= works correctly.....
jeff