This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: correct handling of `.zip' files

Alexandre> How about the attached patch?  Ok to install?

It is ok except for one little nit.

Alexandre> -  if (len > 4 && ! strcmp (filename + len - 4, ".zip"))
Alexandre> +  if (len > 4 && (! strcmp (filename + len - 4, ".zip") ||
Alexandre> +		  ! strcmp (filename + len - 4, ".jar")))

In the GNU coding standards the `||' must appear on the second line:

 if (len > 4 && (! strcmp (filename + len - 4, ".zip")
                 || ! strcmp (filename + len - 4, ".jar")))

Feel free to check it in once this change is made.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]