Re: proposed PATCH: --enable-gc

[Manfred Hollstein <manfred at s-direktnet dot de>]

On Thu, 5 November 1998, 20:59:26, tromey@cygnus.com wrote:

 > The (forthcoming) Java runtime has a --enable-gc configuration switch
 > to let the user choose the garbage collector to use.  The Java front
 > end to the compiler needs to have information about the chosen GC in
 > order to determine which library to add to the link line.
 > 
 > The appended patch (which shows the configure.in change but not the
 > corresponding configure change) adds the necessary machinery to gcc's
 > configure.in.  I'd like to check this in.  Can somebody look at it and
 > approve it (or tell me how to change it)?
 > 
 > Note that gcc's configure.in already has `--enable-objc-gc'; I didn't
 > touch that.

If your new switch is only Java related, I'd suggest to use
`--enable-java-gc' instead of the general `--enable-gc'.

Other than that, your patch looks OK.

manfred

 > 
 > Thu Nov  5 11:50:12 1998  Tom Tromey  <tromey@sanguine.cygnus.com>
 > 
 > 	* Makefile.in (GC): New macro.
 > 	* configure: Rebuilt.
 > 	* configure.in: Recognize --enable-gc argument.  Subst `GC'
 > 	variable.
 > 
 > Tom
 > 
 > Index: Makefile.in
 > ===================================================================
 > RCS file: /cvs/egcs/egcs/gcc/Makefile.in,v
 > retrieving revision 1.192
 > diff -u -r1.192 Makefile.in
 > --- Makefile.in	1998/11/04 19:33:04	1.192
 > +++ Makefile.in	1998/11/06 04:57:01
 > @@ -247,6 +247,7 @@
 >  lang_tree_files=@lang_tree_files@
 >  GCC_THREAD_FILE=@thread_file@
 >  OBJC_BOEHM_GC=@objc_boehm_gc@
 > +GC=@GC@
 >  GTHREAD_FLAGS=@gthread_flags@
 >  # Be prepared for gcc2 merges.
 >  gcc_version=@gcc_version@
 > Index: configure.in
 > ===================================================================
 > RCS file: /cvs/egcs/egcs/gcc/configure.in,v
 > retrieving revision 1.175
 > diff -u -r1.175 configure.in
 > --- configure.in	1998/11/05 01:55:45	1.175
 > +++ configure.in	1998/11/06 04:57:02
 > @@ -270,6 +270,13 @@
 >  fi,
 >  objc_boehm_gc='')
 >  
 > +AC_ARG_ENABLE(gc,
 > +changequote(<<,>>)
 > +<<  --enable-gc=TYPE         choose garbage collector [boehm]>>,
 > +changequote([,])
 > +  GC=$enableval,
 > +  GC=boehm)
 > +
 >  # Determine the host, build, and target systems
 >  AC_CANONICAL_SYSTEM
 >  
 > @@ -4058,6 +4065,7 @@
 >  AC_SUBST(lang_tree_files)
 >  AC_SUBST(thread_file)
 >  AC_SUBST(objc_boehm_gc)
 > +AC_SUBST(GC)
 >  AC_SUBST(gcc_version)
 >  AC_SUBST(gcc_version_trigger)
 >  AC_SUBST(local_prefix)