This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: i386 attribute memory bug
- To: Richard Henderson <rth at cygnus dot com>
- Subject: Re: i386 attribute memory bug
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Wed, 28 Oct 1998 00:26:20 -0700
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <19981027152710.A1565@dot.cygnus.com>you write:
> I discovered the following debugging my flow reorg:
>
> The calculation of attribute memory is not safe. When applied
> to return_internal, we get a segv.
>
> This is because instruction types are defaulted to "integer"
> which assumes two input operands. Return_internal does not,
> and so the system crashes. This comes up when sched2 tries
> to determine the priority of the return.
>
> It is likely that this has not been seen before because basic
> block boundaries were not correct wrt the prologue and epilogue.
>
> The following is the most conservative patch. Instead of
> defaulting instructions to "integer", default them to "other".
How about fixing return_internal instead to specify "other" instead of
changing the default for everything.
Our scheduling is bad enough, this (I suspect) would make it much worse.
jeff