This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch against code duplication
- To: Jeffrey A Law <law at cygnus dot com>
- Subject: Re: Patch against code duplication
- From: Bernd Schmidt <crux at Pool dot Informatik dot RWTH-Aachen dot DE>
- Date: Wed, 7 Oct 1998 14:56:02 +0200 (MET DST)
- cc: egcs-patches at cygnus dot com
> I made two minor updates -- I added some comments before count_one_set. When
> you create new functions make sure to remember to add comments before them.
That seems to be my common failure mode. Sorry about this.
There's another thing I missed in that part of the patch: a prototype
declaration. Speaking of which, what is the status of the patch I sent
a few weeks ago to make it possible to add prototypes for functions
defined in target-specific code? That would enable us to add warnings for
this (-Wmissing-prototypes -Wstrict-prototypes).
Bernd
* loop.c (count_one_set): Add prototype.
Index: loop.c
===================================================================
RCS file: /egcs/carton/cvsfiles/egcs/gcc/loop.c,v
retrieving revision 1.84
diff -u -p -r1.84 loop.c
--- loop.c 1998/10/06 20:38:37 1.84
+++ loop.c 1998/10/07 12:54:13
@@ -291,6 +291,8 @@ static int reg_in_basic_block_p PROTO((r
static int consec_sets_invariant_p PROTO((rtx, int, rtx));
static rtx libcall_other_reg PROTO((rtx, rtx));
static int labels_in_range_p PROTO((rtx, int));
+static void count_one_set PROTO((rtx, rtx, varray_type, rtx *));
+
static void count_loop_regs_set PROTO((rtx, rtx, varray_type, varray_type,
int *, int));
static void note_addr_stored PROTO((rtx, rtx));