This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: egcs-CVS19980928, some more CHILL warning patches
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: egcs-CVS19980928, some more CHILL warning patches
- From: Dave Brolley <brolley at cygnus dot com>
- Date: Wed, 30 Sep 1998 15:55:22 -0400
- CC: egcs-patches at cygnus dot com
- Organization: Cygnus Solutions Canada Ltd
- References: <199809291547.LAA17600@caip.rutgers.edu>
Kaveh R. Ghazi wrote:
> +/* We'd like to include expr.h directly to get this prototype, but
> + because of conflicts between rtl.h & parse.h, we can't. So we fake
> + the last argument as an int instead of an "enum expand_modifier". */
> +extern struct rtx_def* expand_expr PROTO((tree, struct rtx_def *,
> + enum machine_mode, int));
> +
Ugh. I don't like this one. It may not work for compilers that use a different size
than sizeof (int) for enumerated types. What is the problem between rtl.h and parse.h?
> static void
> build_receive_buffer_case_end (label_cnt, buf_list, else_clause)
> - tree label_cnt, buf_list, else_clause;
> + tree label_cnt ATTRIBUTE_UNUSED, buf_list, else_clause;
> {
> struct rc_state_type *rc_state = current_rc_state;
> tree alist;
Why not just remove the parameter like you did in the other cases?
> @@ -2186,7 +2186,7 @@ build_receive_buffer_case_end (label_cnt
> */
> static void
> build_receive_signal_case_end (label_cnt, sig_list, else_clause)
> - tree label_cnt, sig_list, else_clause;
> + tree label_cnt ATTRIBUTE_UNUSED, sig_list, else_clause;
> {
> struct rc_state_type *rc_state = current_rc_state;
> tree alist, temp1;
> @@ -2595,7 +2595,7 @@ build_delay_case_label (eventlist, if_or
> */
> void
> build_delay_case_end (label_cnt, event_list)
> - tree label_cnt, event_list;
> + tree label_cnt ATTRIBUTE_UNUSED, event_list;
> {
> struct dl_state_type *dl_state = current_dl_state;
> rtx dldone = gen_label_rtx ();
> @@ -3210,7 +3210,7 @@ invalidate_buffer_element_mode (bufmode)
>
> tree
> check_queue_size (type, qsize)
> - tree type, qsize;
> + tree type ATTRIBUTE_UNUSED, qsize;
Likewise for these.
Dave