This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: problems with cvs -z9 update


Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at> writes:

> + #!/bin/sh

Please insert a space before the slash; some systems interpret `#! /'
as a magic number:

#! /bin/sh

> + if [ ! -d CVS  -o  ! -f gcc/version.c ]; then

Please make that

if [ ! -d CVS ] || [ ! -f gcc/version.c ]; then

it's more portable; not all `test' programs accept -o

> + cvs -q update -P -d -A

I don't think the `-A' should be here; it defeats the purpose of
egcs_latest_snapshot, for instance

-- 
Alexandre Oliva
mailto:oliva@dcc.unicamp.br mailto:aoliva@acm.org
http://www.dcc.unicamp.br/~oliva
Universidade Estadual de Campinas, SP, Brasil



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]