This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: safe_from_p changes tree code
- To: Craig Burley <burley at gnu dot org>
- Subject: Re: safe_from_p changes tree code
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Tue, 30 Jun 1998 01:14:35 -0600
- cc: mark at markmitchell dot com, martin at mira dot isdn dot cs dot tu-berlin dot de, egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <199806291547.LAA20182@melange.gnu.org>you write:
> >I would rather set/unset the tree code to ERROR_MARK around each
> >recursive call than introduce this new accessor. The new accessor
> >only encourages its usage, which is ugly. The kind of thing that
> >safe_from_p is doing is, IMO, rather unattractive. It's not that
> >there wasn't a good reason for the Craig's patch, but I feel strongly
> >that one should only look at _OPERANDs of things that are
> >expressions.
>
> I agree. I'm quite busy with too many things going on at the moment,
> but if nobody else submits a patch soon, please remind me to do it.
> (It's a pretty simple thing to do, just makes the code a bit bigger
> and unmeasurably slower.)
Likewise. Martin, do you want to take care of making the change? It
ought to be pretty straightforward.
jeff