This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: safe_from_p changes tree code
- To: mark at markmitchell dot com
- Subject: Re: safe_from_p changes tree code
- From: Craig Burley <burley at gnu dot org>
- Date: Mon, 29 Jun 1998 11:47:53 -0400 (EDT)
- CC: martin at mira dot isdn dot cs dot tu-berlin dot de, egcs-patches at cygnus dot com
>I would rather set/unset the tree code to ERROR_MARK around each
>recursive call than introduce this new accessor. The new accessor
>only encourages its usage, which is ugly. The kind of thing that
>safe_from_p is doing is, IMO, rather unattractive. It's not that
>there wasn't a good reason for the Craig's patch, but I feel strongly
>that one should only look at _OPERANDs of things that are
>expressions.
I agree. I'm quite busy with too many things going on at the moment,
but if nobody else submits a patch soon, please remind me to do it.
(It's a pretty simple thing to do, just makes the code a bit bigger
and unmeasurably slower.)
tq vm, (burley)