This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: safe_from_p changes tree code
- To: martin at mira dot isdn dot cs dot tu-berlin dot de
- Subject: Re: safe_from_p changes tree code
- From: Mark Mitchell <mark at markmitchell dot com>
- Date: Sun, 28 Jun 1998 22:53:45 -0700
- CC: egcs-patches at cygnus dot com
- References: <199806290440.GAA00300@mira.isdn.cs.tu-berlin.de>
- Reply-to: mark at markmitchell dot com
>>>>> "Martin" == Martin von Loewis <martin@mira.isdn.cs.tu-berlin.de> writes:
Martin> A recent change in safe_from_p broke --enable-checking; an
Martin> error mark is now accessed as an expression. This patch
Martin> introduces a new access macro.
I would rather set/unset the tree code to ERROR_MARK around each
recursive call than introduce this new accessor. The new accessor
only encourages its usage, which is ugly. The kind of thing that
safe_from_p is doing is, IMO, rather unattractive. It's not that
there wasn't a good reason for the Craig's patch, but I feel strongly
that one should only look at _OPERANDs of things that are
expressions.
--
Mark Mitchell mark@markmitchell.com
Mark Mitchell Consulting http://www.markmitchell.com