This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: safe_from_p changes tree code


>>>>> "Martin" == Martin von Loewis <martin@mira.isdn.cs.tu-berlin.de> writes:

    Martin> A recent change in safe_from_p broke --enable-checking; an
    Martin> error mark is now accessed as an expression. This patch
    Martin> introduces a new access macro.

I would rather set/unset the tree code to ERROR_MARK around each
recursive call than introduce this new accessor.  The new accessor
only encourages its usage, which is ugly.  The kind of thing that
safe_from_p is doing is, IMO, rather unattractive.  It's not that
there wasn't a good reason for the Craig's patch, but I feel strongly
that one should only look at _OPERANDs of things that are
expressions. 

-- 
Mark Mitchell 			mark@markmitchell.com
Mark Mitchell Consulting	http://www.markmitchell.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]