This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: find_mem_givs SMALL_REGISTER_CLASSES patch
- To: rth at cygnus dot com
- Subject: Re: find_mem_givs SMALL_REGISTER_CLASSES patch
- From: john at feith dot com (John Wehle)
- Date: Sun, 28 Jun 1998 15:38:40 -0400
- Cc: law at cygnus dot com, egcs-patches at cygnus dot com
> Not recording givs sounds like a bad plan to me. Have you tried
> my loop patches (mark 12a to appear shortly) to see if they fix
> the problem as well?
I only don't record givs which are already a valid address for the machine.
The potential benefit of recording the giv is less than the potential
performance loss due to causing register spillage on a register poor
machine.
Per your suggestion I tried loop mark 10 (I had forgotten about it) and
the results are:
egcs-19980621 with find_mem_givs patch: 105
egcs-19980621 with loop mark 10 patch: 103
Your patch (judging by its relative size :-) looks like it does more
than my little change. I have no problem with my change being passed
over in favor yours, though if it's going to be a while before it's
installed than we may want to consider using my change in the interim.
-- John
-------------------------------------------------------------------------
| Feith Systems | Voice: 1-215-646-8000 | Email: john@feith.com |
| John Wehle | Fax: 1-215-540-5495 | |
-------------------------------------------------------------------------