This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: egcs CVS 19980621, warning patch part 6/7
- To: egcs-patches at cygnus dot com, rth at cygnus dot com
- Subject: Re: egcs CVS 19980621, warning patch part 6/7
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Fri, 26 Jun 1998 09:48:23 -0400 (EDT)
> From: rth@cygnus.com (Richard Henderson)
>
> In article <199806220159.VAA15521.cygnus.egcs.patches@caip.rutgers.edu>,
> Kaveh R. Ghazi <ghazi@caip.rutgers.edu> wrote:
> > This is warning patch part 6/7. Okay to install?
> >
> >Sun Jun 21 16:39:30 1998 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
> >
> > * alpha.c: Include system.h and toplev.h.
> > (cint8_operand): Mark parameter `mode' with ATTRIBUTE_UNUSED.
> > (const48_operand): Likewise.
> > (mode_width_operand): Likewise.
> > (mode_mask_operand): Likewise.
> > (mul8_operand): Likewise.
> > (current_file_function_operand): Likewise.
> > (signed_comparison_operator): Likewise.
> > (divmod_operator): Likewise.
> > (any_memory_operand): Likewise.
> > (alpha_return_addr): Likewise for parameter `frame'.
> > (alpha_builtin_saveregs): Likewise for parameter `arglist'.
> > (vms_valid_decl_attribute_p): Likewise for parameters `decl' and
> > `attributes'.
>
> Ok.
Installed.
> > (output_prologue): Rename to alpha_output_prologue. Mark
> > parameter `size' with ATTRIBUTE_UNUSED. Use HOST_WIDE_INT_PRINT_DEC
> > in call to fprintf. Fix various format specifiers. Remove unused
> > variables `lab' and `name'.
> > (output_end_prologue): Rename to alpha_output_end_prologue.
> > (alpha_output_epilogue): Rename to alpha_output_end_epilogue.
> > Mark parameter `size' with ATTRIBUTE_UNUSED.
>
> Ok, though this is about to change again due to profiling lossage.
I merged/fixed things and installed it.
> > (check_float_value): Likewise for parameter `overflow'.
> > (alpha_need_linkage): Likewise for parameters `name' and `is_local'.
> >
> > * alpha.h (FUNCTION_PROLOGUE): Define in terms of
> > `alpha_output_prologue'.
> > (FUNCTION_END_PROLOGUE): Define in terms of
> > `alpha_output_end_prologue'.
> > (FUNCTION_EPILOGUE): Define in terms of `alpha_output_epilogue'.
> > (ASM_IDENTIFY_GCC, ASM_IDENTIFY_LANGUAGE): Define as taking an
> > argument.
>
> Ok.
Ditto.
> > (ASM_OUTPUT_SHORT): Use HOST_WIDE_INT_PRINT_DEC in call to fprintf.
> > (ASM_OUTPUT_CHAR): Likewise.
> > (ASM_OUTPUT_BYTE): Cast argument to `int' in call to fprintf.
>
> Why cast on the one and use HOST_WIDE_INT_PRINT_DEC on the others?
> All are by necessity in the range of an int -- just cast them all.
I always like to use HOST_WIDE_INT_PRINT_DEC where possible.
The ASM_OUTPUT_SHORT and ASM_OUTPUT_CHAR macros were always getting a
HOST_WIDE_INT by virtue of printing the INTVAL macro. The
ASM_OUTPUT_BYTE macro was not guaranteed this so I had to use a cast.
But you are correct that they are all values which should fit
in an int, so I switched to all casts, and installed it.
>
> > (PRINT_OPERAND_ADDRESS): Use HOST_WIDE_INT_PRINT_DEC in call to
> > fprintf.
> > (PUT_SDB_EPILOGUE_END): Mention argument `NAME' in definition.
> > Add prototypes for functions in alpha.c.
> >
> > * alpha.md (ashldi3): Add default case in switch.
>
> Ok.
> r~
Also installed.
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu Icon CMT Corp.