This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH for fold-const.c: take 2
- To: law at cygnus dot com
- Subject: Re: PATCH for fold-const.c: take 2
- From: Mark Mitchell <mark at markmitchell dot com>
- Date: Thu, 25 Jun 1998 17:29:09 -0700
- CC: egcs-patches at cygnus dot com
- References: <465.898820062@hurl.cygnus.com>
- Reply-to: mark at markmitchell dot com
>>>>> "Jeffrey" == Jeffrey A Law <law@hurl.cygnus.com> writes:
Jeffrey> In message
Jeffrey> <199806252036.NAA11445@smtp.earthlink.net>you write:
>> The patch I just sent was written while I was under an evil
>> influence, and is total garbage.
>>
>> Here's a better version.
>>
>>
>> Thu Jun 25 12:47:41 1998 Mark Mitchell <mark@markmitchell.com>
>>
>> * fold-const.c (make_range): Don't go looking at TREE_OPERANDs
>> of nodes that are not expressions.
Jeffrey> Just curious -- what kinds of nodes were showing up which
Jeffrey> caused you to look at this?
PARM_DECLs. If you look at the code, you'll see that it was goes
through the loop until it finds something it doesn't understand. On
that last iteration, though, it was still grabbing TREE_OPERANDs. I
found this by configuring with --enable-checking as I was doing one
more test of the type-based alias stuff before checking it in.
--
Mark Mitchell mark@markmitchell.com
Mark Mitchell Consulting http://www.markmitchell.com