This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: egcs CVS 19980621, warning patch part 7/7
- To: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Subject: Re: egcs CVS 19980621, warning patch part 7/7
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Thu, 25 Jun 1998 00:59:49 -0600
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <199806220203.WAA17004@caip.rutgers.edu>you write:
> This is warning patch part 7/7. Okay to install?
I'm going to defer to David Edelsohn on the rs6000 specific bits.
> (I'm not sure about making types SFmode/DFmode in fp-bit.c be explicit
> ints but that's what the message said they defaulted to prior to my patch.
I think this is a bug in the compiler. Those have well defined types
that are not integers :-)
> * Makefile.in (xcoffout.o): Depend on toplev.h and output.h.
Don't forget dbxout.h since you're adding it to the files included
by xcoffout.c.
> * config/fp-bit.c (SFtype, DFtype): Make type `int' explicit.
I think you should omit this change. I think it's actually exposed a
(minor) bug in the compiler.
> (_fpmul_parts): Move variables `x', `ylow', `yhigh' and `bit' into
> the scope in which they are used.
> (_fpdiv_parts): Remove unused variables `low', `high', `r0', `r1',
> `y0', `y1', `q', `remainder', `carry', `d0' and `d1'.
These looks fine.
> * dbxout.h (dbxout_parms, dbxout_reg_parms, dbxout_syms): Add
> prototypes.
Seems fine.
> * xcoffout.c: Include toplev.h, outout.h and dbxout.h.
Likewise.
> * xcoffout.h (stab_to_sclass, xcoffout_begin_function,
> xcoffout_begin_block, xcoffout_end_epilogue,
> xcoffout_end_function, xcoffout_end_block,
> xcoff_output_standard_types, xcoffout_declare_function,
> xcoffout_source_line): Add prototypes.
This seems fine to me too.
jeff