This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: fix for libf2c installation


>This seems to be the right way to fix the problem of libsubdir not
>being defined for libf2c installation.

Manfred already fixed that, but I guess his patch didn't get installed.

Let's wait for that, as I decided a week ago to not bother trying
to have libf2c intuit the relevant data from sibling or parent
directories.

>[I don't understand why INSTALL is set explcitly to the shell script
>rather than configured and why @AR@ and @RANLIB@ aren't used; their
>definitions in configure could be removed as it is.]

Those all seem like bugs to me.  Feel free to fix those!

>  install:
>- 	@if [ x$(libsubdir) = x ]; then \
>- 	  echo ''; \
>- 	  echo 'libf2c error: libsubdir environment variable is not'; \
[...]

This should definitely be left in for now, until we verify that
we no longer see this message in future snapshots.  It does
no harm if Manfred's patch is in, IMO.

>+ # Get the version number from the toplevel
>+ version=`sed -e 's/.*\"\([[^ \"]]*\)[[ \"]].*/\1/' < ${srcdir}/../gcc/version.c`
>+ AC_SUBST(version)
>+ AC_CANONICAL_SYSTEM
>+ AC_SUBST(target_alias)

I don't even know what the AC_CANONICAL_SYSTEM line does, but the other
two AC_ lines look fine, though they *should* be unnecessary with
Manfred's patch.

But definitely the "version=" line should go away.  I tried it myself,
got it to work, but removed it because it's a kludge.  Manfred's
patch has the top-level Makefile pass the relevant info down; maybe
even the top-level configure script, in which case we should use that.

(That way, we can invoke `make' more easily in subdirectories, though
there are probably lots of other warts we have to watch out for
trying that that are yet to be learned about and fixed.  I got
burnt trying to do this myself, then wondering why things didn't
work as expected....)

        tq vm, (burley)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]