This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A revised patch for global.c
- To: hjl at lucon dot org (H.J. Lu)
- Subject: Re: A revised patch for global.c
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Sun, 21 Jun 1998 23:25:22 -0600
- cc: egcs-patches at cygnus dot com
- Reply-To: law at cygnus dot com
In message <m0ynz30-000261C@ocean.lucon.org>you write:
> > It would have helped if you had mentioned that the Makefile.in
> > dependencies already had machmode.h via RTL_H which would have saved
> > me the time to track it down myself.
> >
> > Please do not omit important pieces of information for patches.
> >
>
> I thought it was a well-known fact.
Nope. I certainly didn't know it off the top of my head. I know there
are some dependencies handled in that manner, but I don't know exactly
which ones.
You should not make such assumptions. While many of us have been hacking
gcc for a long time, we don't know everything cold. Assuming that we
do just leads to problems.
jeff