This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: A Linux patch for .p2align
- To: hjl at lucon dot org, law at cygnus dot com
- Subject: Re: A Linux patch for .p2align
- From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
- Date: Fri, 19 Jun 1998 10:27:58 -0400 (EDT)
- Cc: Frank dot Heldt at t-online dot de, egcs-patches at cygnus dot com, egcs at cygnus dot com
> From: Jeffrey A Law <law@cygnus.com>
>
> In message <m0ylMQn-00026AC@ocean.lucon.org>you write:
> > Here is a patch.
> >
> > H.J.
> > ----
> > Fri Jun 12 08:06:55 1998 H.J. Lu (hjl@gnu.org)
> >
> > * config/i386/linux.h (ASM_OUTPUT_MAX_SKIP_ALIGN): Defined.
> > Include <stdio.h>.
>
> I didn't install the stdio.h change; we're trying to move away from
> including stdio.h -- system.h is a better file to include.
> jeff
Yes, but I would not include system.h (or stdio.h or any
system header) from another gcc header like linux.h. The .c file
itself should include system.h right after [h]config.h.
I believe at this point all .c files do this except for
convert.c and c-convert.c (which don't appear to need any system
header or autoconf stuff,) and also some of config/*/*.c. I'm working
on those config/ dir files which I can test. The i386 stuff is not
among them.
So far, the following are done (I didn't do them all, so
thanks for the help, you know who you are...):
sparc.c
m32r.c
mips.c
pa.c
rs6000.c
I'll also be doing alpha.c soon. Its the last native one I have.
Once I finish alpha, perhaps I might build cross compilers to
convert (and test) more config/*/*.c files. But if people with other
platforms where these run native would like to help, they are welcome to
(there are lots of these files.)
Note you don't have to update Makefile.in dependencies for
$out_object_file, I did that the first time I converted a config/ dir
file so all of them have this.
--Kaveh
--
Kaveh R. Ghazi Project Manager / Custom Development
ghazi@caip.rutgers.edu Icon CMT Corp.