This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Regression in unroll.c
- To: richard dot earnshaw at arm dot com
- Subject: Re: Regression in unroll.c
- From: Jeffrey A Law <law at cygnus dot com>
- Date: Wed, 10 Jun 1998 01:51:16 -0600
- cc: egcs-patches at cygnus dot com, wilson at cygnus dot com, kenner at vlsi1 dot ultra dot nyu dot edu
- Reply-To: law at cygnus dot com
In message <199806081018.LAA26822@sun52.NIS.cambridge>you write:
> The gcc2 change of Mar 21 to verify_addresses (and merged into egcs)
> causes a regression on the ARM (execute/920625-1.c) with -funroll-loops).
> The problem is that verify_addresses was modified to use
> validate_replace_rtx so that match_dups would be handled, but the
> corresponding change to the undo at the end of the function wasn't made.
> Since the comment asserts that the undo can't fail, I've also added an
> abort to confirm this.
>
> <date> Richard Earnshaw (rearnsha@arm.com)
>
> * unroll.c (verify_addresses): Use validate_replace_rtx to undo the
> changes. Abort if the undo fails.
This looks good to me. Please install it into egcs.
Thanks!
jeff