This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: egcs 980315 bug on powerpc-unknown-linux-gnulibc1



  In message <v03130301b183416fc8f1@[195.180.235.101]>you write:
  > @@ -4733,7 +4752,7 @@
  >      case ABI_V4:
  >      case ABI_SOLARIS:
  >      case ABI_AIX_NODESC:
  > -      ret = (TARGET_32BIT) ? 40 : 48;
  > +      ret = 48;  /* Keeps stack aligned */
  >        break;
  > 
  >      case ABI_NT:
I do not think this patch is correct.  A "weird" sized trampoline
shouldn't be messing up the alignment of the stack.  If it is, then
there's a bug elsewhere.

Furthermore, if you want to increase the alignment of the trampoline,
the way to do that is by defining TRAMPOLINE_ALIGNMENT.  But I would
recommend first finding out why your stacks are getting mis-aligned
with the current value of TRAMPOLINE_SIZE.


I believe this was one of Gary's patches.  Unfortunately, I don't
have his address handy.  You might want to get in contact with him
to see if he's got a testcase or this problem that we can look at.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]