This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: egcs/gcc patch to speed up compiles of some Fortran code



  In message <199805231618.MAA27338@melange.gnu.org>you write:
  > Sat May 23 08:41:29 1998  Craig Burley  <burley@gnu.org>
  > 
  > 	* expr.c (safe_from_p): Avoid combinatorial explosion
  > 	over duplicate SAVE_EXPRs by ensuring we never recurse
  > 	on one that has already been visited.
I'd prefer we go ahead and handling resizing the array or using a
linked list.  Arbitrary limits are bad.  Yes there are lots of them
in the compiler, but why introduce more when it isn't necessary.

I've got no particular preference to which scheme you use (lists
or an array you can grow via xrealloc) -- whichever you find
easier.

Thanks to everyone else that has commented, especially on the issue
of whether or not it's safe to temporarily stomp on the TREE_CODE
in this manner.  That's an area I know little/nothing about.


jeff



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]