This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug target/79462] [7 Regression] sh: Stack smashing detected when building __ashrdi3 in libgcc


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79462

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
What kind of comment would you like to have?  Normally we document what the
code is supposed to do, but here I can imagine just something like:
  /* We used to clear operands[4] here, which used to be a scratch register,
     but that is no longer the case.  */
which I'm afraid would just confuse rather than explain anything useful.
r235698 removed all other references to operands[4] (also without adding
comment on what it used to be).

(In reply to Kazumoto Kojima from comment #3)

> I've tested the patch with the top "make -k check" on sh4-unknown-linux-gnu
> and there are no regressions.

Thanks.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]