This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug target/67710] FAIL: gcc.dg/darwin-*version-*.c (test for excess errors) with Xcode 7


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67710

--- Comment #13 from Iain Sandoe <iains at gcc dot gnu.org> ---
Author: iains
Date: Sun Nov 27 15:07:22 2016
New Revision: 242898

URL: https://gcc.gnu.org/viewcvs?rev=242898&root=gcc&view=rev
Log:
[Darwin] fix PR67710 by updating 'as' specs to handle newer assembler versions.

A/ Newer versions of ld64 check the min_version command, and newer versions of
   the system assembler inserts this in response to "-mmacosx-version-min=" on
   the assembler line. Unless one makes sensible versions, some object is bound
   to conflict.

B/ Additionally, there's a difference in behaviour between "as" and "ld" when
   presented with xx.yy.zz (ld truncates to xx.yy, as doesn't); net result is
   that one needs to pass a truncated version to "as".

So (if the assembler supports minversion commands)
(a) provide a truncated minversion (as asm_macosx_version_min, which is a
    driver-only var).
(b) pass this to "as"
(c) Update tests to determine 'HAVE_AS_MMACOSX_VERSION_MIN_OPTION'
    (Rainer's patch)
(d) For some reason the testcases are "run" (it's not obvious they need to be,
    they are checking compile-time issues)
  - anyway, to preserve the status quo, I've left them as exec.  However, the
    minimum version that can be code-gened for is target-dependent (there are
no
    released x86 versions before 10.4, for example).  To avoid conflicts where
    the "as" is assuming some minimum, I've set the testversion to 10.5 (which
    is supported by all the archs we have)
(e) We need to ensure that libgcc and crts are generated with a sufficiently
    old minversion not to conflict.

gcc/

2016-11-27  Iain Sandoe  <iain@codesourcery.com>
            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        PR target/67710
        * config.in: Regenerate
        * config/darwin-driver.c (darwin_driver_init): Emit a version string
        for the assembler.
        * config/darwin.h(ASM_MMACOSX_VERSION_MIN_SPEC): New, new tests.
        * config/darwin.opt(asm_macosx_version_min): New.
        * config/i386/darwin.h: Handle ASM_MMACOSX_VERSION_MIN_SPEC.
        * configure: Regenerate
        * configure.ac: Check for mmacosx-version-min handling.

gcc/testsuite/

2016-11-27  Iain Sandoe  <iain@codesourcery.com>
            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
            Dominique d'Humieres  <dominiq@lps.ens.fr>

        PR target/67710
        *  gcc.dg/darwin-minversion-1.c: Update min version check.
        *  gcc.dg/darwin-minversion-2.c: Likewise.
        *  gcc.dg/darwin-minversion-3.c: Likewise.

libgcc/

2016-11-27  Iain Sandoe  <iain@codesourcery.com>
            Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        PR target/67710
        *  config/t-darwin: Default builds to 10.5 codegen.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config.in
    trunk/gcc/config/darwin-driver.c
    trunk/gcc/config/darwin.h
    trunk/gcc/config/darwin.opt
    trunk/gcc/config/i386/darwin.h
    trunk/gcc/configure
    trunk/gcc/configure.ac
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.dg/darwin-minversion-1.c
    trunk/gcc/testsuite/gcc.dg/darwin-minversion-2.c
    trunk/gcc/testsuite/gcc.dg/darwin-minversion-3.c
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/t-darwin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]