This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libfortran/70684] [4.9/5/6/7 Regression] incorrect reading of values from file on Windows


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70684

--- Comment #10 from Jerry DeLisle <jvdelisle at gcc dot gnu.org> ---
(In reply to Ray Donnelly from comment #9)
> Should the other two places - next_char_default () and next_char_internal ()
> -that also do:
> 
> dtp->u.p.at_eol = (c == '\n' || c == EOF);
> 
> not check for '\r' too?

Placing it in next_char_default gives us a regression elsewhere.  I am actually
checking to see if after my patch whether the line above is even needed in
next_char_default.  There are a lot of subtle interactions that go into this
code, so i tread lightly.

I will not close this until I have the initial patch back ported and have done
some more testing and others have had time to do more testing.  If you happen
to find a use case that fails, of course, let me know, and thanks.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]