This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug middle-end/70535] broken nested reductions in openacc parallel regions


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70535

--- Comment #1 from cesar at gcc dot gnu.org ---
Author: cesar
Date: Fri Apr  8 21:09:47 2016
New Revision: 234840

URL: https://gcc.gnu.org/viewcvs?rev=234840&root=gcc&view=rev
Log:
        gcc/
        PR lto/70289
        PR ipa/70348
        PR tree-optimization/70373
        PR middle-end/70533
        PR middle-end/70534
        PR middle-end/70535
        * gimplify.c (gimplify_adjust_omp_clauses): Add or adjust data
        clauses for acc parallel reductions as necessary.  Error on those
        that are private.
        * omp-low.c (scan_sharing_clauses): Don't install variables which
        are used in acc parallel reductions.
        (lower_rec_input_clauses): Remove dead code.
        (lower_oacc_reductions): Add support for reference reductions.
        (lower_reduction_clauses): Remove dead code.
        (lower_omp_target): Don't remap variables appearing in acc parallel
        reductions.
        * tree.h (OMP_CLAUSE_MAP_IN_REDUCTION): New macro.

        gcc/testsuite/
        * c-c++-common/goacc/reduction-5.c: New test.
        * c-c++-common/goacc/reduction-promotions.c: New test.
        * gfortran.dg/goacc/reduction-3.f95: New test.
        * gfortran.dg/goacc/reduction-promotions.f90: New test.

        libgomp/
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gang-np-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gw-np-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-2.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-3.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-4.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-vector-p-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-vector-p-2.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-worker-p-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-1.c: New
test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-2.c: New
test.
        * testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-3.c: New
test.
        * testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-1.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-2.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-3.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-4.c: New
        test.
        * testsuite/libgomp.oacc-c-c++-common/par-reduction-1.c: Add test
        coverage.
        * testsuite/libgomp.oacc-c-c++-common/par-reduction-2.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/parallel-dims.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/parallel-reduction.c: New test.
        * testsuite/libgomp.oacc-c-c++-common/pr70289.c: New test.
        * testsuite/libgomp.oacc-c-c++-common/pr70373.c: New test.
        * testsuite/libgomp.oacc-c-c++-common/reduction-1.c: Add test
        coverage.
        * testsuite/libgomp.oacc-c-c++-common/reduction-2.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/reduction-3.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/reduction-4.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/reduction-5.c: Likewise.
        * testsuite/libgomp.oacc-c-c++-common/reduction-6.c: New test.
        * testsuite/libgomp.oacc-c-c++-common/reduction.h: New test.
        * testsuite/libgomp.oacc-fortran/parallel-reduction.f90: New test.
        * testsuite/libgomp.oacc-fortran/pr70289.f90: New test.
        * testsuite/libgomp.oacc-fortran/reduction-1.f90: Add test coverage.
        * testsuite/libgomp.oacc-fortran/reduction-2.f90: Likewise.
        * testsuite/libgomp.oacc-fortran/reduction-3.f90: Likewise.
        * testsuite/libgomp.oacc-fortran/reduction-4.f90: Likewise.
        * testsuite/libgomp.oacc-fortran/reduction-5.f90: Likewise.
        * testsuite/libgomp.oacc-fortran/reduction-6.f90: Likewise.
        * testsuite/libgomp.oacc-fortran/reduction-7.f90: New test.


Added:
    trunk/gcc/testsuite/c-c++-common/goacc/reduction-5.c
    trunk/gcc/testsuite/c-c++-common/goacc/reduction-promotions.c
    trunk/gcc/testsuite/gfortran.dg/goacc/reduction-3.f95
    trunk/gcc/testsuite/gfortran.dg/goacc/reduction-promotions.f90
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gang-np-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gv-np-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gw-np-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-2.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-3.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-gwv-np-4.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-vector-p-1.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-vector-p-2.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-worker-p-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-2.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/loop-reduction-wv-p-3.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-1.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-2.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-3.c
   
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-loop-comb-reduction-4.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/parallel-reduction.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr70289.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/pr70373.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-6.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction.h
    trunk/libgomp/testsuite/libgomp.oacc-fortran/parallel-reduction.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/pr70289.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-7.f90
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimplify.c
    trunk/gcc/omp-low.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree.h
    trunk/libgomp/ChangeLog
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-reduction-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/par-reduction-2.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/parallel-dims.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-1.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-2.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-3.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c
    trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-5.c
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-1.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-4.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-5.f90
    trunk/libgomp/testsuite/libgomp.oacc-fortran/reduction-6.f90

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]