This is the mail archive of the gcc-bugs@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug target/68945] enable libcilkrts on SPARC


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=68945

--- Comment #3 from Stefan Teleman <stefan.teleman at oracle dot com> ---
(In reply to Eric Botcazou from comment #2)
> Patches need to be posted on the gcc-patches@ mailing-list.
> 
> A few remarks:
> 
>   - SPARC is not a platform/target, only an architecture, so I presume that
> you mean SPARC/Solaris here?

Actually, I also mean to include Linux and the BSD's that still
build on and publish for SPARC. I know that FreeBSD and Gentoo Linux
still build and publish SPARC distros.

> 
>   - you don't need 2 entries in configure.tgt
> 
>   - you don't need 2 entries in the target field of testcases.
> 
>   - you cannot patch Makefile.in directly, go through configure.ac instead.
> 
>   - I don't think that patching runtime/config/generic/os-unix-sysdep.c is
> the way to go, you probably need to create runtime/config/sparc instead.
> 
>   - Why do you test all the possible flavours of macros?
> 
> #if defined(sun) || defined(__sun) || defined(__sun__)
> 
> #ifdef __sun__ is the correct version.

OK, thank you for your comments. I will correct these and resubmit
to the gcc-patches@ mailing list.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]